Juan Hernandez has posted comments on this change. Change subject: tools: Adding Reload Configs Implementation (#825671) ......................................................................
Patch Set 9: My 0.02 €: Making the Java engine-config tool depend on the Python SDK seems conceptually wrong to me. The natural way to call a REST application from Java is what this patch is doing. It is true that it looks complicated, but it is complicated because it is laying out all the required infrastructure (building the URL, handling SSL, handling authentication, etc). If we want to go in this direction in the future (use RESTAPI for configuration management, domain managenement, etc) this is the way to go. If we only want to hack the engine-config tool to support the --reload option then using the Python SDK from the engine-config shell script is ok. However I would rather simplify the shell scripts instead of complicate them and move as much logic/infrastructure as possible to the Java side. In an ideal world we should have a Java SDK in addition to the Python SDK. Then there will be no question that engine-config should use the Java SDK. -- To view, visit http://gerrit.ovirt.org/4951 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b9e790d7a8386359edfd62172df1078da033e91 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Muli Salem <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
