Yair Zaslavsky has posted comments on this change.
Change subject: core: Tar cleanup
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/Tar.java
Line 116: try {
Line 117: os = new FileOutputStream(args[0]);
Line 118: Tar.doTar(os, new File(args[1]));
Line 119: } finally {
Line 120: try {
Good to know.
Any reason why NOT to add it, if you're saying that it exists at GWT?
For some reason I have deja-vu of you using it at engine-code.
Line 121: if (os != null) {
Line 122: os.close();
Line 123: }
Line 124: } catch(IOException e) {
--
To view, visit http://gerrit.ovirt.org/8211
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I766b94086e4696a035b99415f599b16ae78ab94f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
