Alon Bar-Lev has posted comments on this change. Change subject: core: Tar cleanup ......................................................................
Patch Set 3: Hi, I would have split it into two patches. Although fixing the main is not needed as it just for testing... it is one patch. The commons-io is not something I would have put only for the Tar class as we have this in many other classes, so proper patch is to modify all the finally blocks of streams to use this method. Juan, if we use java-1.7, why not use the new sequence try-with-resources[1] statement? Alon [1] http://java.dzone.com/articles/java-7-new-try-resources -- To view, visit http://gerrit.ovirt.org/8211 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I766b94086e4696a035b99415f599b16ae78ab94f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
