Alon Bar-Lev has posted comments on this change. Change subject: core: Tar cleanup ......................................................................
Patch Set 3: I would prefer that you didn't submit this As this is master (3.2) anyway, I vote for try-with-resources at back-end code. It is where java is going, and indeed sane solution after so many years of forcing developers to compensate java authors mind-set of inappropriate scope handling. So no need for extra dependency, and no need for any code change at this time, when time comes (and someone has time) a global patch for usage of try-with-resources within streams will be much better progress. -- To view, visit http://gerrit.ovirt.org/8211 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I766b94086e4696a035b99415f599b16ae78ab94f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
