Alon Bar-Lev has posted comments on this change. Change subject: core: Tar cleanup ......................................................................
Patch Set 3: Again.... There is no point in fixing the main() it is just for manual testing, never actually executed. And As I wrote I intentionally did not put the close on exception there, as it is useless anyway. For the ioutils, if you want to use it, please go over *ALL* the sources and replace the sequence of closing streams with ioutils, there is no point in doing so only in one class. The patch should be "cleanup: use IOUtils.closeQuietly() instead of manual handling", and do just that, no other cleanups. This IOUtils.closeQuietly() was invented to workaround pre-java-7 complexity. However, as I already stated, if I was to go cleanup stream closure, I would have done so at the java-7 way. So I vote keeping code as-is, and in future we go and use the java-7 way. There is absolutely no need to create noise in adding pre-java-7 hacks to the code if we already know that java-7 is here. alon -- To view, visit http://gerrit.ovirt.org/8211 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I766b94086e4696a035b99415f599b16ae78ab94f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
