Itamar Heim has posted comments on this change. Change subject: ShellBox UI plugin - rpmbuild ......................................................................
Patch Set 1: 1. why is there an rpm in the committed files? the rpm is the output of creating it as part of the build from sources? 2. shellbox and shellinabox are two different things, please use the full name. 3. why do you have a tar file, rather than a dependency on the shellinabox rpm? it's even available out of the box on fedora 18 iiuc? -- To view, visit http://gerrit.ovirt.org/11198 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If916c7cf022e9e903cd06e55f7b8ff34851ab9c8 Gerrit-PatchSet: 1 Gerrit-Project: samples-uiplugins Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
