Yair Zaslavsky has posted comments on this change.
Change subject: engine: Fixing RecoveryStoragePool and EventQueue
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/eventqueue/EventQueueMonitor.java
Line 177: LinkedList<Pair<Event,
FutureTask<EventResult>>> queue =
Line 178: new LinkedList<Pair<Event,
FutureTask<EventResult>>>();
Line 179: for (Pair<Event,
FutureTask<EventResult>> task : poolsEventsMap.get(storagePoolId)) {
Line 180: EventType eventType =
task.getFirst().getEventType();
Line 181: if (eventType ==
EventType.VDSCONNECTTOPOOL || (eventType == EventType.RECOVERY &&
!result.isSuccess())) {
Not sure I fully understood why you added the check of "!isSuccess"
Please elaborate? (Was not that clear from commit msg)
Line 182: queue.add(task);
Line 183: } else {
Line 184: log.infoFormat("The following
operation {0} was cancelled, because of recosntruct was run before",
Line 185: task.getFirst());
....................................................
Commit Message
Line 10: 1. The event trigerred by RecoveryStoragePoll will be cleaned from
queue if a previous
Line 11: event was reconstruct and it finished with success
Line 12: 2. The event of RecoveryStoragePool will be added the first to the
queue, because of it was
Line 13: triggered by user
Line 14: 3. Removed a code from RecoveryStoragePool which should prevent a
race, the reason is no race is prevented,
remove the "a" - no need (a code)
Line 15: code was duplicated, the logic was duplicated, the logic should be
simple and rewritted in other way
Line 16:
Line 17: Change-Id: I3b58f095c69c76116f0af44b08ccaf41d1ff1fb8
Line 11: event was reconstruct and it finished with success
Line 12: 2. The event of RecoveryStoragePool will be added the first to the
queue, because of it was
Line 13: triggered by user
Line 14: 3. Removed a code from RecoveryStoragePool which should prevent a
race, the reason is no race is prevented,
Line 15: code was duplicated, the logic was duplicated, the logic should be
simple and rewritted in other way
s/rewritted/rewritten
Line 16:
Line 17: Change-Id: I3b58f095c69c76116f0af44b08ccaf41d1ff1fb8
--
To view, visit http://gerrit.ovirt.org/11201
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b58f095c69c76116f0af44b08ccaf41d1ff1fb8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
