Liron Aravot has posted comments on this change. Change subject: engine: Fixing RecoveryStoragePool and EventQueue ......................................................................
Patch Set 1: I would prefer that you didn't submit this * reload of StoragePool and StorageDomain should be left - otherwise we might perform reconstruct and update the DB with wrong values (ProceedStorageDomainTreatmentByDomainType() method) regardless - the canDoAction() after the fix to the reconstruct return value is indeed will be only relevant in corner cases,I think that we should still have it and be always on the safe side as there's almost no cost for performing it. -- To view, visit http://gerrit.ovirt.org/11201 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b58f095c69c76116f0af44b08ccaf41d1ff1fb8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
