Michael Kublin has posted comments on this change. Change subject: engine: Fixing RecoveryStoragePool and EventQueue ......................................................................
Patch Set 1: "reload of StoragePool and StorageDomain should be left - otherwise we might perform reconstruct and update the DB with wrong values (ProceedStorageDomainTreatmentByDomainType() method)" - which values? If you writing such remarks you should provide a values, before that your remark is useless. Also, we have at least 3,4 processes that running simultaneously and can update a storage pool, so what now we will add reload of all values ? I know at least one strategy that better than these. "regardless, i don't see much benefit in removing the canDoAction() call." - Duplicate code and duplicate logic it is a first symptom of wrong flow and bad code. The first thing that should be done before duplicate some logic, maybe I am doing something wrong. -- To view, visit http://gerrit.ovirt.org/11201 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b58f095c69c76116f0af44b08ccaf41d1ff1fb8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
