Allon Mureinik has posted comments on this change.
Change subject: engine: Fixing RecoveryStoragePool and EventQueue
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(2 inline comments)
minor issues
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/eventqueue/EventQueueMonitor.java
Line 97: * The following method should decide if we want that the event
will be first for executing, before all other events
Line 98: * already submitted to queue
Line 99: * @param event
Line 100: * - submitted event
Line 101: * @return
Either document or remove
Line 102: */
Line 103: private boolean isEventShouldBeFirst(Event event) {
Line 104: return event.getEventType() == EventType.RECOVERY;
Line 105: }
Line 99: * @param event
Line 100: * - submitted event
Line 101: * @return
Line 102: */
Line 103: private boolean isEventShouldBeFirst(Event event) {
why not just shouldEventBeFirst?
Line 104: return event.getEventType() == EventType.RECOVERY;
Line 105: }
Line 106:
Line 107: private FutureTask<EventResult> addTaskToQueue(Event event,
Callable<EventResult> callable, Guid storagePoolId, boolean addFirst) {
--
To view, visit http://gerrit.ovirt.org/11201
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b58f095c69c76116f0af44b08ccaf41d1ff1fb8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
