Yair Zaslavsky has posted comments on this change. Change subject: engine: Removing canDoaction from ConnectHostToStoragePoolServersCommand ......................................................................
Patch Set 1: (2 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectHostToStoragePoolServersCommand.java Line 93 Line 94 Line 95 Line 96 Line 97 What happens if one of the connections is invalid? why not getting it at canDoAction? I did not see such a validation at InitVdsOnUpCommand that calls this command , so not sure if I understand why this is redunant .................................................... Commit Message Line 7: engine: Removing canDoaction from ConnectHostToStoragePoolServersCommand Line 8: Line 9: The following change is removing canDoAction from ConnectHostToStoragePoolServersCommand. Line 10: The purpose of canDoAction was validate storage connections at vdsm, the following API Line 11: is depreacted and not usefull at vdsm side, and not provide any benefit to engine, also and is not useful ... Line 12: the following command is internal so no reason to perfrom additional xml rpc call in order to Line 13: validate storage server connection. Line 14: Benefit, reduced number of XML RPC calls via InitVdsOnUp, meaning vds should be moved to status UP Line 15: much faster. -- To view, visit http://gerrit.ovirt.org/11309 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0124e47b2f1194e5de9b40216cd285c47b1b6f94 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
