Michael Kublin has posted comments on this change. Change subject: engine: Removing canDoaction from ConnectHostToStoragePoolServersCommand ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectHostToStoragePoolServersCommand.java Line 93 Line 94 Line 95 Line 96 Line 97 We don't need. Like I said in description validateConnection is depricated and not efficient API at vds side. So what is a reason to send some XML rpc call to vdsm, which is performing some in efficient chek (By the way in some version it was connect). also how canDoAction helps me in internal command, it not writtent at logs and not passed to user. If connection is invalid a connect will fail. -- To view, visit http://gerrit.ovirt.org/11309 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0124e47b2f1194e5de9b40216cd285c47b1b6f94 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
