Allon Mureinik has posted comments on this change. Change subject: engine: Removing canDoaction from ConnectHostToStoragePoolServersCommand ......................................................................
Patch Set 1: Looks good to me, but someone else must approve (3 inline comments) what about removing the same canDoAction logic from ConnectStorageToVdsCommand and the underlying IStorageHelper.validateStoragePoolConnectionsInHost and the VdsCommand? .................................................... Commit Message Line 5: CommitDate: 2013-01-23 15:31:12 +0200 Line 6: Line 7: engine: Removing canDoaction from ConnectHostToStoragePoolServersCommand Line 8: Line 9: The following change is removing canDoAction from ConnectHostToStoragePoolServersCommand. s/is removing/removes/ Line 10: The purpose of canDoAction was validate storage connections at vdsm, the following API Line 11: is depreacted and not usefull at vdsm side, and not provide any benefit to engine, also Line 12: the following command is internal so no reason to perfrom additional xml rpc call in order to Line 13: validate storage server connection. Line 6: Line 7: engine: Removing canDoaction from ConnectHostToStoragePoolServersCommand Line 8: Line 9: The following change is removing canDoAction from ConnectHostToStoragePoolServersCommand. Line 10: The purpose of canDoAction was validate storage connections at vdsm, the following API s/was/was to/ s/vdsm/VDSM/ Line 11: is depreacted and not usefull at vdsm side, and not provide any benefit to engine, also Line 12: the following command is internal so no reason to perfrom additional xml rpc call in order to Line 13: validate storage server connection. Line 14: Benefit, reduced number of XML RPC calls via InitVdsOnUp, meaning vds should be moved to status UP Line 7: engine: Removing canDoaction from ConnectHostToStoragePoolServersCommand Line 8: Line 9: The following change is removing canDoAction from ConnectHostToStoragePoolServersCommand. Line 10: The purpose of canDoAction was validate storage connections at vdsm, the following API Line 11: is depreacted and not usefull at vdsm side, and not provide any benefit to engine, also s/not provide/doesn't provide/ Line 12: the following command is internal so no reason to perfrom additional xml rpc call in order to Line 13: validate storage server connection. Line 14: Benefit, reduced number of XML RPC calls via InitVdsOnUp, meaning vds should be moved to status UP Line 15: much faster. -- To view, visit http://gerrit.ovirt.org/11309 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0124e47b2f1194e5de9b40216cd285c47b1b6f94 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
