Michael Kublin has submitted this change and it was merged. Change subject: engine: Removing canDoaction from ConnectHostToStoragePoolServersCommand ......................................................................
engine: Removing canDoaction from ConnectHostToStoragePoolServersCommand The following change is removes canDoAction from ConnectHostToStoragePoolServersCommand. The purpose of canDoAction was to validate storage connections at VDSM, the following API is depreacted and not useful at vdsm side, and doesn't provide any benefit to engine, also the following command is internal so no reason to perfrom additional xml rpc call in order to validate storage server connection. Benefit, reduced number of XML RPC calls via InitVdsOnUp, meaning vds should be moved to status UP much faster. Additional benefit, less code, less bugs Change-Id: I0124e47b2f1194e5de9b40216cd285c47b1b6f94 Signed-off-by: Michael Kublin <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectHostToStoragePoolServersCommand.java 1 file changed, 8 insertions(+), 42 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11309 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0124e47b2f1194e5de9b40216cd285c47b1b6f94 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
