Vojtech Szocs has posted comments on this change.
Change subject: webadmin,userportal: Improve form-based sub tabs
......................................................................
Patch Set 2: (1 inline comment)
As this patch moves away from Grid, there's an issue with label width being set
globally to 120px for all detail columns [FormItem.ui.xml]. For some very long
labels like "Cluster Compatibility Version" this might cut-off the label.
Maybe we should extend FormBuilder API to control label width per each detail
column? [I really don't want to use Grid/FlexTable again just for layout
purposes]
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/FormItem.java
Line 64: }
Line 65: }
Line 66:
Line 67: void setItemName(String name) {
Line 68: if (name != null && !name.trim().isEmpty()) {
Good idea, will update condition, thanks Alex.
Line 69: nameLabel.setText(name + ":"); //$NON-NLS-1$
Line 70: } else {
Line 71: nameLabel.setText(name);
Line 72: }
--
To view, visit http://gerrit.ovirt.org/12325
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b2f2577b1b488d5514dc05c2590a2bb53fcfe4f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
