Vojtech Szocs has posted comments on this change. Change subject: webadmin,userportal: Improve form-based sub tabs ......................................................................
Patch Set 3: Verified New patch ready for review, includes following changes: * FormBuilder.setColumnLabelWidth() can now be used to override default label width for given detail view * Verified all forms in WebAdmin and UserPortal using main-tab-area-width=1200px, adjusted label widths as necessary via FormBuilder.setColumnLabelWidth() * Removed FormItemWithDefaultValue as it was based on previous version of FormItem, default value functionality implemented via FormItem.withDefaultValue() method * FormItem's value widget is now a dedicated TextBoxLabel, its text is determined via FormItem.resolveValue() method Some findings encountered during verification: * SubTabClusterGeneralView shows the form on right-hand side, which reduces overall form panel width and makes it impossible to adjust label widths using main-tab-area-width=1200px * SubTabHostGeneralView contains form item that's too long and should be shortened: Max free Memory for scheduling new VMs -- To view, visit http://gerrit.ovirt.org/12325 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b2f2577b1b488d5514dc05c2590a2bb53fcfe4f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
