Einav Cohen has posted comments on this change. Change subject: webadmin,userportal: Improve form-based sub tabs ......................................................................
Patch Set 2: > Maybe we should extend FormBuilder API to control label > width per each detail column? [I really don't want to > use Grid/FlexTable again just for layout purposes] +1. probably need to supply a method overload/default-value (to prevent enforcing each consumer of this API to explicitly specify the width). [Many thanks to Derez for noticing this issue and suggesting the above improvement for Vojtech's suggested solution] -- To view, visit http://gerrit.ovirt.org/12325 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b2f2577b1b488d5514dc05c2590a2bb53fcfe4f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
