Vojtech Szocs has posted comments on this change. Change subject: webadmin,userportal: Improve form-based sub tabs ......................................................................
Patch Set 2: > What is the behavior before changing out of the grid? Before this patch - FormBuilder.showForm did following: * remove all items (name/value widgets) from all detail views (represented by 2-column Grid widgets) * re-add all items to corresponding detail views (label widget was always re-created, value widget was reused) * item properties such as visibility were updated only when re-adding items * FormItem, even though it extends Composite, isn't a proper GWT widget (e.g. doesn't use initWidget inside constructor) After this patch - FormBuilder.update will do following: * only update existing items (name/value widgets) * FormItem is a proper GWT widget representing name/value pair (instead of handling name/value widgets outside FormItem) > Would the text wrap (this should be a style sheet setting). Or does it get > cut of as well? We intentionally prevent text wrapping (CSS white-space:nowrap) to retain overall layout, allowing text wrapping would cause the label height to increase and it wouldn't look nice. I'll update the patch and make it possible for callers to override default label width (120px) per each detail view. -- To view, visit http://gerrit.ovirt.org/12325 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b2f2577b1b488d5514dc05c2590a2bb53fcfe4f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
