Alissa Bonas has posted comments on this change.
Change subject: core: Allow force re-election of a specific host as SPM
......................................................................
Patch Set 2: (7 inline comments)
my comments here are only cosmetics, because it's hard to understand the design
/new logic from going over the patch. so whenever you can explain f2f the logic
changes here - we can review it together.
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ReinitializeSPMParameters.java
Line 3: import org.ovirt.engine.core.compat.Guid;
Line 4:
Line 5: public class ReinitializeSPMParameters extends VdcActionParametersBase {
Line 6:
Line 7: private Guid prefferedSPMId;
prefered should be with one 'f'. and probably with 2 'r' :)
Line 8: private Guid storagePoolId = Guid.Empty;
Line 9:
Line 10: public ReinitializeSPMParameters(Guid storagePoolId, Guid
prefferedSPMId) {
Line 11: setStoragePoolId(storagePoolId);
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/ResetIrsVDSCommandParameters.java
Line 12: this(storagePoolId, vdsId);
Line 13: setPrefferedSPMId(prefferedSPMId);
Line 14: }
Line 15:
Line 16: private Guid privateVdsId;
Members of class should come first thing before constructors or method in Java
proper style.
Line 17:
Line 18: private Guid prefferedSPMId;
Line 19:
Line 20: public Guid getVdsId() {
....................................................
File
backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties
Line 17: job.ExportVmTemplate=Exporting VM Template ${VmTemplate} To Export
Domain ${Storage}
Line 18: job.AddDisk=Adding Disk ${DiskAlias}
Line 19: job.RemoveDisk=Removing Disk ${DiskAlias}
Line 20: job.ImportVm=Importing VM ${VM} to Cluster ${VdsGroups}
Line 21: job.ReinitializeSPM=Reinitializing SPM for Data Center ${StoragePool}
if it's possible, I'd add here the new SPM host name.
Line 22: job.RemoveVmFromImportExport=Removing VM ${VM} image from Storage
Domain ${Storage}
Line 23: job.RemoveVmTemplateFromImportExport=Removing VM Template
${VmTemplate} image from Storage Domain ${Storage}
Line 24: job.ImportVmTemplate=Importing VM Template ${VmTemplate} to Data
Center ${StoragePool}
Line 25: job.AddVds=Adding new Host ${VDS} to Cluster ${VdsGroups}
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/SpmStopOnIrsVDSCommandParameters.java
Line 2:
Line 3: import
org.ovirt.engine.core.common.vdscommands.IrsBaseVDSCommandParameters;
Line 4: import org.ovirt.engine.core.compat.Guid;
Line 5:
Line 6: public class SpmStopOnIrsVDSCommandParameters extends
IrsBaseVDSCommandParameters {
it's clearer to call it "StopSPM" and not "SPMStop"
Line 7: public SpmStopOnIrsVDSCommandParameters(Guid storagePoolId) {
Line 8: super(storagePoolId);
Line 9: }
Line 10:
Line 12: super(storagePoolId);
Line 13: setPrefferedSPMId(prefferedSPMId);
Line 14: }
Line 15:
Line 16: private Guid prefferedSPMId;
member should be at top of the class, and prefered is with one 'f'.
Line 17:
Line 18: public Guid getPrefferedSPMId() {
Line 19: return prefferedSPMId;
Line 20: }
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
Line 1057:
Line 1058: @DefaultStringValue("Maintenance")
Line 1059: String maintenanceHost();
Line 1060:
Line 1061: @DefaultStringValue("Make SPM")
Suggesting "Set as SPM" instead "Make SPM"
Line 1062: String makeHostSPM();
Line 1063:
Line 1064: @DefaultStringValue("Confirm 'Host has been Rebooted'")
Line 1065: String confirmRebootedHost();
....................................................
File
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
Line 79: VDS_CANNOT_REMOVE_VDS_STATUS_ILLEGAL=Cannot ${action} ${type}. Host is
operational. Please switch Host to Maintenance mode first.
Line 80: VDS_NOT_EXIST=Cannot ${action} ${type}. Internal Error: Host does not
exists in DB.
Line 81: CANNOT_REINIT_SPM_VDS_NOT_UP=Cannot ${action} ${type}. The host
${VdsName} is not active.
Line 82: CANNOT_REINIT_SPM_VDS_ALREADY_SPM=Cannot ${action} ${type}. The host
${VdsName} is already SPM or contending.
Line 83: CANNOT_REINIT_SPM_VDS_MARKED_AS_NEVER_SPM=Cannot ${action} ${type}.
The host ${VdsName} SPM priority is never.
this is not a very clear English : "The host ... SPM priority is never". I
would suggest something like "This host's SPM priority is set to 'never'" , or
"The host abc has SPM priority set to 'never'."
Line 84: VDS_PROTOCOL_ERROR=Internal error: Host protocol error.
Line 85: VDS_RESPONSE_ERROR=Internal error: Host response error
Line 86: VDS_STATUS_NOT_VALID_FOR_STOP=Cannot perform Stop operation, Host has
to be in Maintenance mode in order to be stopped.
Line 87: VDS_STATUS_NOT_VALID_FOR_START=Cannot perform Start operation, Host
has to be in one of the following statuses: Down ,Non-Responsive or Maintenance.
--
To view, visit http://gerrit.ovirt.org/12489
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife292b85270e6aa8f5bf723ad7d3fa84e325d3d8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
