Maor Lipchuk has posted comments on this change.
Change subject: core: Allow force re-election of a specific host as SPM
......................................................................
Patch Set 2: (4 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ReinitializeSPMCommand.java
Line 58: getParameters().getPrefferedSPMId());
Line 59: runVdsCommand(VDSCommandType.SpmStopOnIrs, params);
Line 60: setSucceeded(true);
Line 61: }
Line 62:
What about audit log, to print an event is this operation succeeded or not.
Line 63: @Override
Line 64: protected void setActionMessageParameters() {
Line 65:
addCanDoActionMessage(VdcBllMessages.VAR__ACTION__REINITIALIZE);
Line 66: addCanDoActionMessage(VdcBllMessages.VAR__TYPE__SPM);
....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 77: VDS_CANNOT_REMOVE_VDS_DETECTED_RUNNING_VM=Cannot ${action} ${type}.
One or more VMs are still running on this Host.
Line 78: VDS_CANNOT_REMOVE_VDS_GROUP_VDS_DETECTED=Cannot ${action} ${type}.
Host Cluster contains one or more Hosts.
Line 79: VDS_CANNOT_REMOVE_VDS_STATUS_ILLEGAL=Cannot ${action} ${type}. Host is
operational. Please switch Host to Maintenance mode first.
Line 80: VDS_NOT_EXIST=Cannot ${action} ${type}. Internal Error: Host does not
exists in DB.
Line 81: CANNOT_REINIT_SPM_VDS_NOT_UP=Cannot ${action} ${type}. The host
${VdsName} is not active.
s/host/Host
Line 82: CANNOT_REINIT_SPM_VDS_ALREADY_SPM=Cannot ${action} ${type}. The host
${VdsName} is already SPM or contending.
Line 83: CANNOT_REINIT_SPM_VDS_MARKED_AS_NEVER_SPM=Cannot ${action} ${type}.
The host ${VdsName} SPM priority is never.
Line 84: VDS_PROTOCOL_ERROR=Internal error: Host protocol error.
Line 85: VDS_RESPONSE_ERROR=Internal error: Host response error
Line 78: VDS_CANNOT_REMOVE_VDS_GROUP_VDS_DETECTED=Cannot ${action} ${type}.
Host Cluster contains one or more Hosts.
Line 79: VDS_CANNOT_REMOVE_VDS_STATUS_ILLEGAL=Cannot ${action} ${type}. Host is
operational. Please switch Host to Maintenance mode first.
Line 80: VDS_NOT_EXIST=Cannot ${action} ${type}. Internal Error: Host does not
exists in DB.
Line 81: CANNOT_REINIT_SPM_VDS_NOT_UP=Cannot ${action} ${type}. The host
${VdsName} is not active.
Line 82: CANNOT_REINIT_SPM_VDS_ALREADY_SPM=Cannot ${action} ${type}. The host
${VdsName} is already SPM or contending.
s/host/Host
Line 83: CANNOT_REINIT_SPM_VDS_MARKED_AS_NEVER_SPM=Cannot ${action} ${type}.
The host ${VdsName} SPM priority is never.
Line 84: VDS_PROTOCOL_ERROR=Internal error: Host protocol error.
Line 85: VDS_RESPONSE_ERROR=Internal error: Host response error
Line 86: VDS_STATUS_NOT_VALID_FOR_STOP=Cannot perform Stop operation, Host has
to be in Maintenance mode in order to be stopped.
Line 79: VDS_CANNOT_REMOVE_VDS_STATUS_ILLEGAL=Cannot ${action} ${type}. Host is
operational. Please switch Host to Maintenance mode first.
Line 80: VDS_NOT_EXIST=Cannot ${action} ${type}. Internal Error: Host does not
exists in DB.
Line 81: CANNOT_REINIT_SPM_VDS_NOT_UP=Cannot ${action} ${type}. The host
${VdsName} is not active.
Line 82: CANNOT_REINIT_SPM_VDS_ALREADY_SPM=Cannot ${action} ${type}. The host
${VdsName} is already SPM or contending.
Line 83: CANNOT_REINIT_SPM_VDS_MARKED_AS_NEVER_SPM=Cannot ${action} ${type}.
The host ${VdsName} SPM priority is never.
s/host/Host
Also consider rephrasing "SPM priority
is never." to something more readable
Line 84: VDS_PROTOCOL_ERROR=Internal error: Host protocol error.
Line 85: VDS_RESPONSE_ERROR=Internal error: Host response error
Line 86: VDS_STATUS_NOT_VALID_FOR_STOP=Cannot perform Stop operation, Host has
to be in Maintenance mode in order to be stopped.
Line 87: VDS_STATUS_NOT_VALID_FOR_START=Cannot perform Start operation, Host
has to be in one of the following statuses: Down ,Non-Responsive or Maintenance.
--
To view, visit http://gerrit.ovirt.org/12489
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife292b85270e6aa8f5bf723ad7d3fa84e325d3d8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
