Vered Volansky has posted comments on this change.
Change subject: core: Allow force re-election of a specific host as SPM
......................................................................
Patch Set 2: (5 inline comments)
....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 79: VDS_CANNOT_REMOVE_VDS_STATUS_ILLEGAL=Cannot ${action} ${type}. Host is
operational. Please switch Host to Maintenance mode first.
Line 80: VDS_NOT_EXIST=Cannot ${action} ${type}. Internal Error: Host does not
exists in DB.
Line 81: CANNOT_REINIT_SPM_VDS_NOT_UP=Cannot ${action} ${type}. The host
${VdsName} is not active.
Line 82: CANNOT_REINIT_SPM_VDS_ALREADY_SPM=Cannot ${action} ${type}. The host
${VdsName} is already SPM or contending.
Line 83: CANNOT_REINIT_SPM_VDS_MARKED_AS_NEVER_SPM=Cannot ${action} ${type}.
The host ${VdsName} SPM priority is never.
a. This has to be changed, you don't have possessive here and you can't add it
at the current state of the sentence.
b. How about (trying to solve both issues): The SPM priority of
Host ${VdsName} is set to never. This Host can never be elected as SPM.
Line 84: VDS_PROTOCOL_ERROR=Internal error: Host protocol error.
Line 85: VDS_RESPONSE_ERROR=Internal error: Host response error
Line 86: VDS_STATUS_NOT_VALID_FOR_STOP=Cannot perform Stop operation, Host has
to be in Maintenance mode in order to be stopped.
Line 87: VDS_STATUS_NOT_VALID_FOR_START=Cannot perform Start operation, Host
has to be in one of the following statuses: Down ,Non-Responsive or Maintenance.
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
Line 121: }
Line 122:
Line 123: protected static class IrsProxyData {
Line 124: // TODO the syncObj initial purpose was to lock the IrsBroker
creation
Line 125: // but eventually because the IRS is single threaded and
suppose to have
/s/suppose/supposed
Only because you're already at it. This comment is wrong in so many ways, I
don't think you'd want to get into that.
Line 126: // quite a load of requests,
Line 127: // In order to avoid unexpected behavior we have used the
syncObj to
Line 128: // lock each request to the IRS
Line 129: // and by that we caused a serialization of requests to the
IRS.
Line 134: private final String storagePoolRefreshJobId;
Line 135: private final java.util.HashSet<Guid> mTriedVdssList = new
java.util.HashSet<Guid>();
Line 136: private Guid mCurrentVdsId;
Line 137:
Line 138: private Guid prefferedHost;
Make sure to change to preferred here as well
Line 139:
Line 140: public Guid getCurrentVdsId() {
Line 141: return getIrsProxy() != null ? mCurrentVdsId : Guid.Empty;
Line 142: }
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
Line 1057:
Line 1058: @DefaultStringValue("Maintenance")
Line 1059: String maintenanceHost();
Line 1060:
Line 1061: @DefaultStringValue("Make SPM")
This should be propagated into HostListModel naming as well
Line 1062: String makeHostSPM();
Line 1063:
Line 1064: @DefaultStringValue("Confirm 'Host has been Rebooted'")
Line 1065: String confirmRebootedHost();
....................................................
File
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
Line 79: VDS_CANNOT_REMOVE_VDS_STATUS_ILLEGAL=Cannot ${action} ${type}. Host is
operational. Please switch Host to Maintenance mode first.
Line 80: VDS_NOT_EXIST=Cannot ${action} ${type}. Internal Error: Host does not
exists in DB.
Line 81: CANNOT_REINIT_SPM_VDS_NOT_UP=Cannot ${action} ${type}. The host
${VdsName} is not active.
Line 82: CANNOT_REINIT_SPM_VDS_ALREADY_SPM=Cannot ${action} ${type}. The host
${VdsName} is already SPM or contending.
Line 83: CANNOT_REINIT_SPM_VDS_MARKED_AS_NEVER_SPM=Cannot ${action} ${type}.
The host ${VdsName} SPM priority is never.
+1 on the first suggestion.
Line 84: VDS_PROTOCOL_ERROR=Internal error: Host protocol error.
Line 85: VDS_RESPONSE_ERROR=Internal error: Host response error
Line 86: VDS_STATUS_NOT_VALID_FOR_STOP=Cannot perform Stop operation, Host has
to be in Maintenance mode in order to be stopped.
Line 87: VDS_STATUS_NOT_VALID_FOR_START=Cannot perform Start operation, Host
has to be in one of the following statuses: Down ,Non-Responsive or Maintenance.
--
To view, visit http://gerrit.ovirt.org/12489
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife292b85270e6aa8f5bf723ad7d3fa84e325d3d8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
