Mark Wu has posted comments on this change.
Change subject: Allow creating ISO domain on localfs
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterStorageListModel.java
Line 562: String localStorgaeDC = null;
Line 563: for (StorageDomain a : Linq.<StorageDomain>
Cast(getSelectedItems()))
Line 564: {
Line 565: // For local storage - remove; otherwise - detach
Line 566: if (a.getStorageType() == StorageType.LOCALFS &&
a.getStorageDomainType() != StorageDomainType.ISO)
the remove cause a format on the storage domain. If the administrator really
want to format it, it can click the checkbox of 'format storage domain' in the
dialog of removing storage domain after detaching from the DC. Without
the change in line 566, it's always be formated on detach
Line 567: {
Line 568: getpb_remove().add(new
RemoveStorageDomainParameters(a.getId()));
Line 569: localStorgaeDC = a.getStoragePoolName();
Line 570: }
--
To view, visit http://gerrit.ovirt.org/12687
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a8d3ea8ab4ac10353ec8574287458e8eb63e882
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
