Allon Mureinik has posted comments on this change.
Change subject: Allow creating ISO domain on localfs
......................................................................
Patch Set 3: (4 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddLocalStorageDomainCommand.java
Line 46: setStoragePool(storagePool);
Line 47: }
Line 48:
Line 49: if (retVal && getStorageDomain().getStorageDomainType() !=
StorageDomainType.ISO
Line 50: && storagePool.getstorage_pool_type() !=
StorageType.LOCALFS) {
I misread your patch, my bad.
please disregard.
Line 51:
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_POOL_IS_NOT_LOCAL);
Line 52: retVal = false;
Line 53: }
Line 54:
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommand.java
Line 78
Line 79
Line 80
Line 81
Line 82
storage connection management is a fishy flow as-is, and some day should be
completely rewritten (read: removed :-)).
Currently, adding a domain is not an atomic operation in the backend - it's
governed by the caller (GUI or REST).
If you look at the relevant UI code (see, e.g.,
org.ovirt.engine.ui.uicommonweb.models.storage.StorageListModel.SaveNewLocalStorage()),
it connects, adds the domain and disconnect.
Since this is the flow, AddStorageServerConnectionCommand can not be expected
to do these validations.
IMHO, it's OK.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DisconnectStorageServerConnectionCommand.java
Line 35
Line 36
Line 37
Line 38
Line 39
same answer :-)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterStorageListModel.java
Line 562: String localStorgaeDC = null;
Line 563: for (StorageDomain a : Linq.<StorageDomain>
Cast(getSelectedItems()))
Line 564: {
Line 565: // For local storage - remove; otherwise - detach
Line 566: if (a.getStorageType() == StorageType.LOCALFS &&
a.getStorageDomainType() != StorageDomainType.ISO)
Fair enough
Line 567: {
Line 568: getpb_remove().add(new
RemoveStorageDomainParameters(a.getId()));
Line 569: localStorgaeDC = a.getStoragePoolName();
Line 570: }
--
To view, visit http://gerrit.ovirt.org/12687
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a8d3ea8ab4ac10353ec8574287458e8eb63e882
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
