Allon Mureinik has posted comments on this change.
Change subject: Allow creating ISO domain on localfs
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddLocalStorageDomainCommand.java
Line 45: } else {
Line 46: setStoragePool(storagePool);
Line 47: }
Line 48:
Line 49: if (retVal && getStorageDomain().getStorageDomainType() !=
StorageDomainType.ISO
Additionally, consider checking that the storage domain in a data domain
(StorageDomain().getStorageDomainType() == StorageDomainType.DATA) instead of
checking it isn't an ISO domain - IMHO, it will make the code easier to
understand.
Line 50: && storagePool.getstorage_pool_type() !=
StorageType.LOCALFS) {
Line 51:
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_POOL_IS_NOT_LOCAL);
Line 52: retVal = false;
Line 53: }
--
To view, visit http://gerrit.ovirt.org/12687
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a8d3ea8ab4ac10353ec8574287458e8eb63e882
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
