Allon Mureinik has posted comments on this change.
Change subject: Allow creating ISO domain on localfs
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DisconnectStorageServerConnectionCommand.java
Line 20: }
Line 21:
Line 22: @Override
Line 23: protected boolean canDoAction() {
Line 24: return true;
Also, assuming this is indeed correct (pending Alissa's response), it's
meaningless to have a canDoAction() that just returns true - you should simply
remove this method.
Line 25: }
Line 26:
Line 27: protected boolean disconnectStorage() {
Line 28: return Backend.getInstance()
--
To view, visit http://gerrit.ovirt.org/12687
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a8d3ea8ab4ac10353ec8574287458e8eb63e882
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
