Allon Mureinik has posted comments on this change.
Change subject: core: Moves VmPropertiesUtils to CustomPropetiesUtils
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java
Line 308: protected IsoDomainListSyncronizer getIsoDomainListSyncronizer() {
Line 309: return IsoDomainListSyncronizer.getInstance();
Line 310: }
Line 311:
Line 312: protected CustomPropertiesUtils getVmPropertiesUtils() {
the name should probably be changed to getCustomPropertiesUtils()
Line 313: return CustomPropertiesUtils.getInstance();
Line 314: }
Line 315:
Line 316: protected boolean validate(ValidationResult validationResult,
List<String> message) {
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/customprop/CustomPropertiesUtils.java
Line 28: public class CustomPropertiesUtils {
Line 29:
Line 30: private static CustomPropertiesUtils vmPropertiesUtils = null;
Line 31:
Line 32: public static CustomPropertiesUtils getInstance() {
and make the instance final while you're at it :-)
Line 33: if (vmPropertiesUtils == null) {
Line 34: synchronized (CustomPropertiesUtils.class) {
Line 35: if (vmPropertiesUtils == null) {
Line 36: vmPropertiesUtils = new CustomPropertiesUtils();
--
To view, visit http://gerrit.ovirt.org/14813
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib18a622a1d02f444c6bdc1e22c2f92f93c52757e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
