Yair Zaslavsky has posted comments on this change.
Change subject: core: Prepare custom device properties support in
VmPropertiesUtils
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/customprop/VmPropertiesUtils.java
Line 27:
Line 28: private static VmPropertiesUtils vmPropertiesUtils = null;
Line 29:
Line 30: public static VmPropertiesUtils getInstance() {
Line 31: if (vmPropertiesUtils == null) {
While you're at it, fix the initialization here, same way as you did with the
singleton for Device Custom Properties.
Line 32: synchronized (VmPropertiesUtils.class) {
Line 33: if (vmPropertiesUtils == null) {
Line 34: vmPropertiesUtils = new VmPropertiesUtils();
Line 35: }
--
To view, visit http://gerrit.ovirt.org/14813
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib18a622a1d02f444c6bdc1e22c2f92f93c52757e
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
