Yair Zaslavsky has posted comments on this change.
Change subject: core: Prepare custom device properties support in
VmPropertiesUtils
......................................................................
Patch Set 5: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmCustomPropertiesQuery.java
Line 5: import org.ovirt.engine.core.common.queries.VdcQueryParametersBase;
Line 6: import org.ovirt.engine.core.compat.Version;
Line 7: import org.ovirt.engine.core.utils.customprop.VmPropertiesUtils;
Line 8:
Line 9: public class GetVmCustomPropertiesQuery<P extends
VdcQueryParametersBase> extends QueriesCommandBase<P> {
Sorry for remembering this only now,
Similar Query should be add to get all the custom properties,
And I assume it should be per device type.
Using this, frontend will be able to get the required regex at edit network
(for example).
This should probably be intoduced at the next patch in your patchset, which
introduces the proper utility.
Don't forget to add an entry at VdcQueryType.
Line 10:
Line 11: private static final String Version3_0 = "3.0";
Line 12:
Line 13: public GetVmCustomPropertiesQuery(P parameters) {
--
To view, visit http://gerrit.ovirt.org/14813
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib18a622a1d02f444c6bdc1e22c2f92f93c52757e
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
