Moti Asayag has posted comments on this change. Change subject: core: Prepare custom device properties support in VmPropertiesUtils ......................................................................
Patch Set 5: In reply to: "A small question, after your refactoring can I reuse custom properties logic (parsing, validation, etc..) on other components?" I don't see any reason why not to do so. It is under org.ovirt.engine.core.utils namespace, therefore it could serve any component which it visible to. perhaps in such case (obviously not in any of current patches) a better name space would be just: org.ovirt.engine.core.utils.properties Would you share a specific use-case? -- To view, visit http://gerrit.ovirt.org/14813 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib18a622a1d02f444c6bdc1e22c2f92f93c52757e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
