Martin Peřina has posted comments on this change.
Change subject: core: Adds SSH soft fencing capability
......................................................................
Patch Set 3: (4 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/FenceVdsActionParameters.java
Line 10:
Line 11: /**
Line 12: * Indicator to execute VDSM restart using SSH
Line 13: */
Line 14: private final boolean executeSshVdsmRestart;
Well your suggestion doesn't comply with Java Coding Conventions, but what
about this?
private final boolean executeSshSoftFencing;
public boolean shouldExecuteSshSoftFencing() {}
Line 15:
Line 16: public FenceVdsActionParameters() {
Line 17: this.executeSshVdsmRestart = false;
Line 18: }
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
Line 93: }
Line 94:
Line 95: private final AtomicInteger mFailedToRunVmAttempts;
Line 96: private final AtomicInteger mUnrespondedAttempts;
Line 97: private final AtomicBoolean sshSoftFencingExecuted;
Oops, sorry I've missed it. What about to rename the method to
sshSoftFencingExecutionCallback() ?
Line 98:
Line 99: private static final int VDS_DURING_FAILURE_TIMEOUT_IN_MINUTES =
Config
Line 100: .<Integer>
GetValue(ConfigValues.TimeToReduceFailedRunOnVdsInMinutes);
Line 101: private String duringFailureJobId;
Line 610: (Config.<Double>
GetValue(ConfigValues.DelayResetPerVmInSeconds) * vmCount));
Line 611:
Line 612: if (sshSoftFencingExecuted.get()) {
Line 613: // VDSM restart by SSH has been executed, wait more to
see if host is OK
Line 614: secToFence = 2 * secToFence;
The secToFence time has been used to wait before real rencing has been
executed. When SSH soft fencing has been added into the flow, we will have to
wait if SSH soft fencing helped and if it didn't then execute standard fencing.
For further explanation please see VdsManager.handleNetworkException() and page
http://www.ovirt.org/Automatic_Fencing#Automatic_Fencing_in_oVirt_3.3
Line 615: }
Line 616:
Line 617: return TimeUnit.SECONDS.toMillis(secToFence);
Line 618: }
Line 653: boolean executeSshSoftFencing = false;
Line 654: if (!sshSoftFencingExecuted.getAndSet(true)) {
Line 655: executeSshSoftFencing = true;
Line 656: }
Line 657:
ResourceManager.getInstance().getEventListener().vdsNotResponding(vds,
executeSshSoftFencing);
VdsManager handles communication with not responding hosts, it's the only place
to store if SSH Soft Fencing had already been executed for the host.
Line 658: }
Line 659: return true;
Line 660: }
Line 661:
--
To view, visit http://gerrit.ovirt.org/15798
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8002b6ac00a1e2e543b5cc8d1affdd42b994d5f7
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
