Yair Zaslavsky has posted comments on this change.
Change subject: core: Adds SSH Soft Fencing capability
......................................................................
Patch Set 5: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java
Line 63: protected void executeCommand() {
Line 64: setVds(null);
Line 65: if (getVds() != null && shouldVdsBeFenced()) {
Line 66: boolean sshVdsmRestartSuccess = false;
Line 67: if (getParameters().shouldExecuteSshSoftFencing()) {
Once again, sorry for being late here.
In general, I think parameters should conform to java bean notations, so Martin
was right with isXXX prefix.
Line 68: sshVdsmRestartSuccess =
Line 69:
executeRestartVDSMUsingSsh(getVds().getHostName(),
getVds().getVdsGroupCompatibilityVersion()
Line 70: .toString());
Line 71: }
Line 209: * @return initialized SSH client instance
Line 210: * @throws KeyStoreException
Line 211: * if engine SSH key pair cannot be loaded
Line 212: */
Line 213: private SSHClient getSshClient(String host) throws
KeyStoreException {
Please use the SSHClientWrapper which was recently introduced by alonbl.
Line 214: SSHClient sshClient = new SSHClient();
Line 215: sshClient.setHardTimeout(TimeUnit.SECONDS.toMillis(
Line 216: Config.<Integer>
GetValue(ConfigValues.SSHInactivityHardTimoutSeconds)));
Line 217: sshClient.setSoftTimeout(TimeUnit.SECONDS.toMillis(
--
To view, visit http://gerrit.ovirt.org/15798
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8002b6ac00a1e2e543b5cc8d1affdd42b994d5f7
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
