Yaniv Bronhaim has posted comments on this change.
Change subject: core: Adds SSH Soft Fencing capability
......................................................................
Patch Set 7: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java
Line 61: }
Line 62:
Line 63: if (sshVdsmRestartSuccess) {
Line 64: // tell VDSManager to wait if VDSM restart using SSH
helped
Line 65:
ResourceManager.getInstance().GetVdsManager(getVds().getId()).sshSoftFencingExecutionCallback(getVds());
instead of calling here to a function that only set the status to connecting
(without any callback meanings), just getVds().setStatus(connecting..) does the
same thing. otherwise change the name of it, because it's not act as callback
function does.
Line 66: } else {
Line 67: // executing VDSM restart using SSH was not
successful, execute standard fencing
Line 68: super.executeCommand();
Line 69: }
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
Line 734: // reset the unresponded counter to wait if VDSM restart helps
Line 735: mUnrespondedAttempts.set(0);
Line 736: // change VDS state to connecting
Line 737: setStatus(VDSStatus.Connecting, vds);
Line 738: UpdateDynamicData(vds.getDynamicData());
why do you update dynamic data here? the status is only kept in cache
Line 739: }
--
To view, visit http://gerrit.ovirt.org/15798
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8002b6ac00a1e2e543b5cc8d1affdd42b994d5f7
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
