Yaniv Bronhaim has posted comments on this change.
Change subject: core: Adds SSH Soft Fencing capability
......................................................................
Patch Set 7: (3 inline comments)
Just minor comments to make the code more clear. not a must.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java
Line 60: .toString());
Line 61: }
Line 62:
Line 63: if (sshVdsmRestartSuccess) {
Line 64: // tell VDSManager to wait if VDSM restart using SSH
helped
comment is redundant here, could be placed in the function itself to understand
what it does. And explain why connecting state tells VdsManager to wait if you
decide to keep the comment
Line 65:
ResourceManager.getInstance().GetVdsManager(getVds().getId()).sshSoftFencingExecutionCallback(getVds());
Line 66: } else {
Line 67: // executing VDSM restart using SSH was not
successful, execute standard fencing
Line 68: super.executeCommand();
Line 61: }
Line 62:
Line 63: if (sshVdsmRestartSuccess) {
Line 64: // tell VDSManager to wait if VDSM restart using SSH
helped
Line 65:
ResourceManager.getInstance().GetVdsManager(getVds().getId()).sshSoftFencingExecutionCallback(getVds());
just change the name from sshSoftFencingExecutionCallback to
endingSshSoftFencingExecution. It's just that "callback" is mostly related to
async processes, and here its not the case.
Line 66: } else {
Line 67: // executing VDSM restart using SSH was not
successful, execute standard fencing
Line 68: super.executeCommand();
Line 69: }
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
Line 734: // reset the unresponded counter to wait if VDSM restart helps
Line 735: mUnrespondedAttempts.set(0);
Line 736: // change VDS state to connecting
Line 737: setStatus(VDSStatus.Connecting, vds);
Line 738: UpdateDynamicData(vds.getDynamicData());
Ok, you're right. I saw that we don't update db in all the other calls in
handleNetworkException to setStatus(), but after handling the exception we do
that
Line 739: }
--
To view, visit http://gerrit.ovirt.org/15798
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8002b6ac00a1e2e543b5cc8d1affdd42b994d5f7
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
