Martin Peřina has posted comments on this change.
Change subject: core: Adds SSH Soft Fencing capability
......................................................................
Patch Set 12: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SshSoftFencingCommand.java
Line 41: return;
Line 42: }
Line 43:
Line 44: validator = new VdsValidator(getVds());
Line 45: if (validator.shouldVdsBeFenced()) {
Again it's same approach as in VdsNotRespondingTreatmentCommand and I think
it's safe to check this just before execution
Line 46: result =
executeSshSoftFencingCommand(getVds().getHostName(),
Line 47:
getVds().getVdsGroupCompatibilityVersion().toString());
Line 48: if (result) {
Line 49: // SSH Soft Fencing executed without errors, tell
VdsManager about it
Line 71:
Line 72: try {
Line 73: sshClient = new EngineSSHClient();
Line 74: sshClient.setHost(host);
Line 75: sshClient.setUser("root");
Well, I could do this, but I don't see a reason. This is only place where is
this SSH client initialized, so the username is used only there. Also the port
is default, I don't set it there.
Line 76: sshClient.useDefaultKeyPair();
Line 77: sshClient.connect();
Line 78: sshClient.authenticate();
Line 79: ByteArrayOutputStream bos = new ByteArrayOutputStream();
--
To view, visit http://gerrit.ovirt.org/15798
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8002b6ac00a1e2e543b5cc8d1affdd42b994d5f7
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
