Martin Peřina has posted comments on this change.
Change subject: core: Adds SSH Soft Fencing capability
......................................................................
Patch Set 11: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SshSoftFencingCommand.java
Line 32: @Override
Line 33: protected boolean canDoAction() {
Line 34: boolean result = true;
Line 35: if (getVds() == null) {
Line 36:
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_HOST_NOT_EXIST);
Well, I thought it would be safer to check this just before execution. It's the
same as in VdsNotRespondingTreatment. But you are right, the check should be
done only in one place ...
Line 37: result = false;
Line 38: }
Line 39:
Line 40: getReturnValue().setSucceeded(result);
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java
Line 131:
ExecutionHandler.createInternalJobContext());
Line 132: sshSoftFencingSuccessful = retVal.getSucceeded();
Line 133:
Line 134: }
Line 135: if (!sshSoftFencingSuccessful) {
Renamed sshSoftFencingSuccessful -> shouldExecRealFencing and added a comment.
Line 136:
Backend.getInstance().runInternalAction(VdcActionType.VdsNotRespondingTreatment,
Line 137: new FenceVdsActionParameters(vds.getId(),
FenceActionType.Restart),
Line 138:
ExecutionHandler.createInternalJobContext());
Line 139: }
--
To view, visit http://gerrit.ovirt.org/15798
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8002b6ac00a1e2e543b5cc8d1affdd42b994d5f7
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
