Yair Zaslavsky has posted comments on this change.
Change subject: core: Adds SSH Soft Fencing capability
......................................................................
Patch Set 11: (1 inline comment)
Hi Martin,
One question on canDoAction - and about the "elaboration comment" - may worth
adding a comment in the code that explains this better? I understand the flow,
but I think it will be better for future readers of the code.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java
Line 131:
ExecutionHandler.createInternalJobContext());
Line 132: sshSoftFencingSuccessful = retVal.getSucceeded();
Line 133:
Line 134: }
Line 135: if (!sshSoftFencingSuccessful) {
but actually, the success here is kinda misleading, right? because a true
success is if host gets to Up.
So we will return to vdsNotResponding, if the ssh soft restart did not bring
host to up, right?
Can you elaborate with these code changes, how eventually the host will be
fenced?
Line 136:
Backend.getInstance().runInternalAction(VdcActionType.VdsNotRespondingTreatment,
Line 137: new FenceVdsActionParameters(vds.getId(),
FenceActionType.Restart),
Line 138:
ExecutionHandler.createInternalJobContext());
Line 139: }
--
To view, visit http://gerrit.ovirt.org/15798
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8002b6ac00a1e2e543b5cc8d1affdd42b994d5f7
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
