Yaniv Bronhaim has posted comments on this change.

Change subject: core: Adds SSH Soft Fencing capability
......................................................................


Patch Set 12: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SshSoftFencingCommand.java
Line 71: 
Line 72:         try {
Line 73:             sshClient = new EngineSSHClient();
Line 74:             sshClient.setHost(host);
Line 75:             sshClient.setUser("root");
after rebasing you will see that we just added new 2 variable to vds object, 
one for ssh port and one for ssh user - you will change it, so please use a 
variable for that.
Line 76:             sshClient.useDefaultKeyPair();
Line 77:             sshClient.connect();
Line 78:             sshClient.authenticate();
Line 79:             ByteArrayOutputStream bos = new ByteArrayOutputStream();


-- 
To view, visit http://gerrit.ovirt.org/15798
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8002b6ac00a1e2e543b5cc8d1affdd42b994d5f7
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to