Allon Mureinik has posted comments on this change.
Change subject: engine: StorageConnections ops won't assume VDS
......................................................................
Patch Set 1: (2 inline comments)
Agree with both inline comments - will fix.
Regarding questions:
> 1. are storagepool/host id passed properly in
> delete/update usecase in StorageListModel?
Re delete - the UI does not orchestrate connection removal.
It calls RemoveStorageDomain, which internally removes the connection, with the
given VdsId.
This has not changed.
Re update - Yes, this was not changed.
> 2. what about REST? currently we do require host to be
> passed (and validate it) in both storagedomains resource,
Updating domains really requires a host - this was not changed.
> and in the future (not merged yet) connections resource.
should be changed :-)
> So the restriction/requirement should be removed, AND
> documented in REST documentation - since it affects the
> actual behavior of the action (with/without
> connect/disconnect attempts)
agreed.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommand.java
Line 48: success = false;
Line 49: }
Line 50: }
Line 51:
Line 52: setSucceeded(success);
Done
Line 53:
Line 54: if (success) {
Line 55: connection.setid(Guid.newGuid().toString());
Line 56: saveConnection(connection);
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommandTest.java
Line 26: import org.ovirt.engine.core.dao.StorageServerConnectionDAO;
Line 27: import org.ovirt.engine.core.utils.MockEJBStrategyRule;
Line 28:
Line 29: @RunWith(MockitoJUnitRunner.class)
Line 30: public class AddStorageServerConnectionCommandTest {
good point, will do
Line 31: @ClassRule
Line 32: public static MockEJBStrategyRule ejbRule = new
MockEJBStrategyRule();
Line 33:
Line 34: private
AddStorageServerConnectionCommand<StorageServerConnectionParametersBase>
command = null;
--
To view, visit http://gerrit.ovirt.org/17288
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I628bf2a63f64d3acaa3520ad144e1eef744f1204
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
