Allon Mureinik has posted comments on this change.
Change subject: engine: StorageConnections ops won't assume VDS
......................................................................
Patch Set 2: (6 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommand.java
Line 23:
Line 24: @LockIdNameAttribute
Line 25: @InternalCommandAttribute
Line 26: public class AddStorageServerConnectionCommand<T extends
StorageServerConnectionParametersBase> extends
Line 27: ConnectStorageToVdsCommand<T> {
Not a bad idea, but it invloves a lot of code re-working.
I prefer doing this in a separate patch.
Line 28: public AddStorageServerConnectionCommand(T parameters) {
Line 29: super(parameters);
Line 30: }
Line 31:
Line 96
Line 97
Line 98
Line 99
Line 100
Yes, this is dead code - no flow sends an empty VdsId.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommand.java
Line 146: }
Line 147: }
Line 148: Guid storageDomainId = lun.getStorageDomainId();
Line 149: if (storageDomainId != null) {
Line 150: StorageDomain domain =
getStorageDomainDao().get(storageDomainId);
will fix
Line 151: if
(!domain.getStatus().equals(StorageDomainStatus.Maintenance)) {
Line 152: String domainName = domain.getStorageName();
Line 153: problematicDomainNames.add(domainName);
Line 154: } else {
Line 216: if (isDomainUpdateRequired) {
Line 217: for (StorageDomain domain : domains) {
Line 218: for (StoragePoolIsoMap map :
getStoragePoolIsoMap(domain)) {
Line 219: restoreStateAfterUpdate(map);
Line 220: }
Not a bad optimization, but let's leave it to another patch.
Line 221: }
Line 222: if (hasConnectStorageSucceeded) {
Line 223: disconnectFromStorage();
Line 224: }
Line 288:
Line 289: protected boolean connectToStorage() {
Line 290: StorageServerConnectionManagementVDSParameters
newConnectionParametersForVdsm =
Line 291: createParametersForVdsm(getParameters().getVdsId(),
Line 292: Guid.Empty,
It's not needed.
Will remove it throughout the system in a separate patch.
Line 293:
getParameters().getStorageServerConnection().getstorage_type(),
Line 294: getParameters().getStorageServerConnection());
Line 295: return runVdsCommand(VDSCommandType.ConnectStorageServer,
newConnectionParametersForVdsm).getSucceeded();
Line 296: }
....................................................
Commit Message
Line 11: (If a host is passed, connection information is validated).
Line 12:
Line 13: This patch decouples storage connection commands from storage domain
Line 14: commands, and stops assuming the presence of a host and/or a storage
Line 15: pool.
will fix
Line 16:
Line 17: Change-Id: I628bf2a63f64d3acaa3520ad144e1eef744f1204
--
To view, visit http://gerrit.ovirt.org/17288
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I628bf2a63f64d3acaa3520ad144e1eef744f1204
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
