Alissa Bonas has posted comments on this change.
Change subject: engine: StorageConnections ops won't assume VDS/SP
......................................................................
Patch Set 3: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java
Line 67: executeInScope(TransactionScopeOption.Suppress, new
TransactionMethod<Void>() {
Line 68: @Override
Line 69: public Void runInTransaction() {
Line 70: int master_domain_version =
Line 71:
getStoragePoolDAO().increaseStoragePoolMasterVersion(getStoragePool().getId());
what is the change here? just formatting?
I don't mind leaving it as it is now here and in other places in this patch,
but you always request to remove formatting noise from patches, so...
Line 72:
getStoragePool().setmaster_domain_version(master_domain_version);
Line 73: return null;
Line 74: }
Line 75: });
--
To view, visit http://gerrit.ovirt.org/17288
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I628bf2a63f64d3acaa3520ad144e1eef744f1204
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
