Alissa Bonas has posted comments on this change.
Change subject: engine: StorageConnections ops won't assume VDS
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(2 inline comments)
commit message doesn't mention the storagePoolId change, it's important to
state it there as well.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommand.java
Line 146: }
Line 147: }
Line 148: Guid storageDomainId = lun.getStorageDomainId();
Line 149: if (storageDomainId != null) {
Line 150: StorageDomain domain =
getStorageDomainDao().get(storageDomainId);
missing handling of extracting the correct status here
Line 151: if
(!domain.getStatus().equals(StorageDomainStatus.Maintenance)) {
Line 152: String domainName = domain.getStorageName();
Line 153: problematicDomainNames.add(domainName);
Line 154: } else {
....................................................
Commit Message
Line 11: (If a host is passed, connection information is validated).
Line 12:
Line 13: This patch decouples storage connection commands from storage domain
Line 14: commands, and stops assuming the presence of a host and/or a storage
Line 15: pool.
commit message doesn't mention the storagePoolId change, it's important to
state it there as well.
Line 16:
Line 17: Change-Id: I628bf2a63f64d3acaa3520ad144e1eef744f1204
--
To view, visit http://gerrit.ovirt.org/17288
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I628bf2a63f64d3acaa3520ad144e1eef744f1204
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
