On 22/09/11 13:14, Govindaraju SM wrote: > ==> There are use case which requires multiple lines together. Strikeout > uses line with different height offset. > For Example, A underlined, Strike out word with Wrong spell will have 3 > lines and all three can co-exist with different colors. > But I agree your point about Evas Line drawing optimization.
Ok, I now understand what you are trying to achieve, you want for example a dashed red line with a black line behind it (so the gaps will appear black) for example. In order to mark text that already has an underline. Anyhow, I think it's better to change the property strings accordingly: dashwidth -> underline_dash_width dashgap -> underline_dash_gap dashed_line_color -> underline_dash_color Also, your patch doesn't comply with the coding conventions. An example to that would be the spaces between the variables and the commas in "int i,j,dx,dn; \" or between the divisor and the divided in: "dn = itr->w/(dw + dp); \" and possibly more formatting errors I currently missed because I just skimmed through them (haven't applied the patch and looked in VIM yet. Please adjust those as well. Reminder: please include a test (src/tests/evas_test_textblock.c) to your next patch, as I mentioned in the previous email. -- Tom. ------------------------------------------------------------------------------ All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity and more. Splunk takes this data and makes sense of it. Business sense. IT sense. Common sense. http://p.sf.net/sfu/splunk-d2dcopy1 _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
