In SVN, thanks.

I fixed a compilation warning (Shadowed variable) and 1/2 coding 
conventions mistakes.

--
Tom.

On 12/10/11 14:26, SHILPAONKAR SINGH wrote:
> Hi All,
>
> Please find attached updated dashed underline patch with review comment fixes 
> given by Tom.
>
> Fixes: tag names and function name modified, formatting fixes and test added 
> for dashed underline.
>
> and I agree as multiple underlines should not co-exist only one underline 
> color tag will be sufficient.
> and I think even in case of double underline we should still have only one 
> underline color tag and apply the same
> color to both lines.
>
> but there is an exceptional case also where in a "underline" can be drawn 
> over other underline (eg: to indicate Spellcheck error -squiggly
> red underline)  so this case also needs to be considered. may be for this 
> case a boolean tag can be used to indicate that this line can be drawn
> over other underline and a special color tag also may be required.
>
> Thanks&  Regards
> Shilpa Singh
> ------- Original Message -------
> Sender : Tom Hacohen<tom.haco...@partner.samsung.com>  Engineer/STRI-SLP RTL 
> Language supporting/Samsung Electronics
> Date : Sep 22, 2011 17:30 (GMT+09:00)
> Title : Re: [E-devel] Evas Patch - Dashed Underline Support
>
> On 22/09/11 05:39, SHILPAONKAR SINGH wrote:
>> Hi All,
>>
>> The attached patch adds dashed underline support to evas_object_textblock.
>> dashed underline can be enabled by assigning "dashed" value to underline tag.
>> dash underline's parameters can be controlled by manipulating dashgap and
>> dashwidth tags to get different sized dash lines(by making dashgap=1 and 
>> dashwidth=1
>> we can even get dotted style).
>> Please review the patch and let me know your opinion.
>
> Thanks for the patch, I reviewed it and it looks good, but I have 1
> comment, and one thing I'm not entirely sure about.
>
> Comment: DRAW_FORMAT_SPEC should probably be named DRAW_FORMAT_DASHED.
>
> As for what I'm not sure of:
> Since underline, dashed-line, and in the future, squiggly-line, can't
> co-exist (or at least shouldn't), it makes sense (to me) that all the
> colours will be shared among all the underlines, and that we'll have an
> enum defining the underline style. This is neater, and also, this will
> let us easily extend dashed-line and squiggly-line to work with
> underline2 (but not a must).
>
> Bottom line, I suggest keeping it internally in an enum instead of a
> couple of booleans so the structure will be nicer, what do you think?
>
>
> Also, please add related tests to evas's test infrastructure
> (src/tests/evas_test_textblock.c).
>
> Thanks,
> Tom.


------------------------------------------------------------------------------
All the data continuously generated in your IT infrastructure contains a
definitive record of customers, application performance, security
threats, fraudulent activity and more. Splunk takes this data and makes
sense of it. Business sense. IT sense. Common sense.
http://p.sf.net/sfu/splunk-d2d-oct
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to