On 22/09/11 13:42, Sebastian Dransfeld wrote:
> On 09/22/2011 12:39 PM, Tom Hacohen wrote:
>> Also, your patch doesn't comply with the coding conventions. An example
>> to that would be the spaces between the variables and the commas in "int
>> i,j,dx,dn; \" or between the divisor and the divided in:
>> "dn = itr->w/(dw + dp); \" and possibly more formatting errors I
>> currently missed because I just skimmed through them (haven't applied
>> the patch and looked in VIM yet. Please adjust those as well.
>
> Can you see in vim if the formatting does not match the vim indent settings?

Kinda:

1. I can see if there are white errors, i.e usage of tabs/trailing whites.
2. I easily spot errors when in VIM (where I'm used to seeing code) v.s 
thunderbird's preview. It just catches my eye.
3. Also, usually before applying patches, I mark all the relevant pieces 
of code, and press '=' to make it indent according to VIM's indent 
settings. Then I just check if there were any changes. But usually, when 
I get to this stage, I just commit and send a notice about the errors 
(Unless there are too many, and then I ask for another patch).

But it's usually the first two, the last one is only when I'm about to 
commit and already decided the patch is good, clean, and follows the 
guidelines.

With that being said, I'm pretty sure there's a way to make vim 
highlight formatting errors, either a built-in option/plugin, or by 
writing a plugin on our own. :)

--
Tom.


------------------------------------------------------------------------------
All the data continuously generated in your IT infrastructure contains a
definitive record of customers, application performance, security
threats, fraudulent activity and more. Splunk takes this data and makes
sense of it. Business sense. IT sense. Common sense.
http://p.sf.net/sfu/splunk-d2dcopy1
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to