This is not right. GoUn Lee sent a patch to mailing list for the code review and this is not reviewed enough on the mailing list.
And I don't think one year internal around means this code is correct and does not have to be reviewed enough even I know it works. Impatient mike! Anyhow, I disagree with this decision. Once this happens, we can't guarantee this will not happen again. And GoUn will lose her chance to be reviewed her code enough by open source e-developers. Daniel Juyung Seo (SeoZ) On Thu, Nov 24, 2011 at 10:42 AM, Michael Blumenkrantz <[email protected]> wrote: > On Thu, 24 Nov 2011 10:35:09 +0900 > Mike McCormack <[email protected]> wrote: > >> >> On 11/24/2011 10:10 AM, Michael Blumenkrantz wrote: >> >> > umm...unless I'm mistaken this was not given NEARLY enough time to be >> > reviewed on the list. and as you are an author, you cannot self-review... >> >> Sorry to rush. >> >> My judgement is that this will go in one way or the other at some point. It >> has been around internally for one year, is in constant use, etc. >> >> It's not a prototype that somebody thought up yesterday and is suddenly >> pushing today. >> >> IMO, it should have been upstreamed and committed much sooner, so I'm a bit >> impatient to get the damn thing merged. >> >> Sorry to step on your toes. >> >> I'll do my best to make sure that the review comments are addressed. >> >> Mike > I understand your position, but if this is the case then it should never have > been submitted to the mailing list to begin with. > > ------------------------------------------------------------------------------ > All the data continuously generated in your IT infrastructure > contains a definitive record of customers, application performance, > security threats, fraudulent activity, and more. Splunk takes this > data and makes sense of it. IT sense. And common sense. > http://p.sf.net/sfu/splunk-novd2d > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
