On Thu, 24 Nov 2011 11:33:22 +0900 Mike McCormack <[email protected]> wrote:
> On 11/24/2011 11:12 AM, Daniel Juyung Seo wrote: > > This is not right. > > GoUn Lee sent a patch to mailing list for the code review and this is > > not reviewed enough on the mailing list. > > > > And I don't think one year internal around means this code is correct > > and does not have to be reviewed enough even I know it works. > > > > Impatient mike! > > Anyhow, I disagree with this decision. Once this happens, we can't > > guarantee this will not happen again. And GoUn will lose her chance to > > be reviewed her code enough by open source e-developers. > > Goun is only the internal maintainer of this code, not the original author. > > It has be contributed to by many people internally, which I have tried to > reflect in the commit message. > > Most code committed to EFL (say 90%) is not reviewed on the mailing list. > Has code review suddenly become a priority? :-) > > thanks, > > Mike The point is that this was submitted for review and then committed after people spent time reading through the code without giving sufficient time for actual review. This wastes peoples' time and will likely demotivate future reviews. ------------------------------------------------------------------------------ All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
