On Thu, Nov 24, 2011 at 11:33 AM, Mike McCormack <[email protected]> wrote: > On 11/24/2011 11:12 AM, Daniel Juyung Seo wrote: >> This is not right. >> GoUn Lee sent a patch to mailing list for the code review and this is >> not reviewed enough on the mailing list. >> >> And I don't think one year internal around means this code is correct >> and does not have to be reviewed enough even I know it works. >> >> Impatient mike! >> Anyhow, I disagree with this decision. Once this happens, we can't >> guarantee this will not happen again. And GoUn will lose her chance to >> be reviewed her code enough by open source e-developers. > > Goun is only the internal maintainer of this code, not the original author.
She has been maintained this code for about 10 months. And she changed a lot. Talking about the original author is meaningless anymore. She maintains it. > > It has be contributed to by many people internally, which I have tried to > reflect in the commit message. > > Most code committed to EFL (say 90%) is not reviewed on the mailing list. > Has code review suddenly become a priority? :-) > Committed code without review was done by committer and the person has a responsibility for the code. The code for review on the mailing list has to be review enough. This is not a "sudden" issue. It was already there. DID YOU REVIEW THE CODE? > thanks, > > Mike > > ------------------------------------------------------------------------------ > All the data continuously generated in your IT infrastructure > contains a definitive record of customers, application performance, > security threats, fraudulent activity, and more. Splunk takes this > data and makes sense of it. IT sense. And common sense. > http://p.sf.net/sfu/splunk-novd2d > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > Daniel Juyung Seo (SeoZ) ------------------------------------------------------------------------------ All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
