Hello. On 28/03/13 13:25, Michael Blumenkrantz wrote: > > also can I request that you please backport this to the 1.7 branch? thanks > :)
Before we do that we could have a look at the evas textblock unit test this change broke: Line 598 error out: 576 const char *buf_wb = "a This is_a t:e.s't a"; 577 evas_object_textblock_text_markup_set(tb, buf_wb); 578 579 /* Word start/end */ 580 evas_textblock_cursor_pos_set(cur, 3); 581 evas_textblock_cursor_word_start(cur); 582 fail_if(2 != evas_textblock_cursor_pos_get(cur)); 583 evas_textblock_cursor_word_end(cur); 584 fail_if(5 != evas_textblock_cursor_pos_get(cur)); 585 586 evas_textblock_cursor_pos_set(cur, 13); 587 evas_textblock_cursor_word_end(cur); 588 fail_if(18 != evas_textblock_cursor_pos_get(cur)); 589 evas_textblock_cursor_word_start(cur); 590 fail_if(12 != evas_textblock_cursor_pos_get(cur)); 591 evas_textblock_cursor_word_start(cur); 592 fail_if(12 != evas_textblock_cursor_pos_get(cur)); 593 evas_textblock_cursor_word_start(cur); 594 fail_if(12 != evas_textblock_cursor_pos_get(cur)); 595 evas_textblock_cursor_word_end(cur); 596 fail_if(18 != evas_textblock_cursor_pos_get(cur)); 597 evas_textblock_cursor_word_end(cur); 598 fail_if(21 != evas_textblock_cursor_pos_get(cur)); 599 600 /* Bug with 1 char word separators at paragraph start. */ 601 evas_object_textblock_text_markup_set(tb, "=test"); 602 evas_textblock_cursor_pos_set(cur, 4); 603 evas_textblock_cursor_word_start(cur); 604 fail_if(1 != evas_textblock_cursor_pos_get(cur)); So we are at the wrong position. - fail_if(18 != evas_textblock_cursor_pos_get(cur)); + fail_if(21 != evas_textblock_cursor_pos_get(cur)); Fixes it but that seems like behaviour change of the released API to me. We are not longer at the end of t:e.s't but one postion after a. This has the potential to give us some real trouble with evas_textblock_cursor_pos_get used in apps. Do I miss something? The tested text buffer looks not like a corner case for me. regards Stefan Schmidt ------------------------------------------------------------------------------ Own the Future-Intel® Level Up Game Demo Contest 2013 Rise to greatness in Intel's independent game demo contest. Compete for recognition, cash, and the chance to get your game on Steam. $5K grand prize plus 10 genre and skill prizes. Submit your demo by 6/6/13. http://p.sf.net/sfu/intel_levelupd2d _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
