On Tue, Dec 13, 2016 at 11:54 AM, Stefan Schmidt <[email protected]> wrote: > Hello. > > On 13/12/16 14:09, Felipe Magno de Almeida wrote: >> On Tue, Dec 13, 2016 at 8:28 AM, Stefan Schmidt <[email protected]> >> wrote: >>> Hello. >> >> [snip] >> >>> I fully agree (even have native IPv6 here) but we need to be defensive >>> what we expect to be available in our test suite. >> >> Why? It is testing, I agree we should need to be defensive in the >> implementation and interfaces where EFL might run in stranger >> environments, > > If the implementation would handle this all gracefully the test would > never had been a problem. :)
no no... the code gracefully handles that, but the test is explicit "resolve ::1 to ::1 and I expect it to work". The test itself should be conditional and I'm willing to do that, HOWEVER our test bots should have IPv6 so we check that code. > but a test that fails on a machine that doesn't >> handle IPv6 seems fine to me as long as it is rare enough. > > We assume IPv6 now, we assume a working internet connection, we assume > udev for eeze testing, we assume a working dbus setup, in some cases we > assume a file system which supports extended attributes, etc... > > If it is complicated to run make check we will have even less people > running it. It should be the other way around. I guess I could look at > anybody here who contributed a few patches this year and see someone who > broke make check. If it is to complicated or fails for some reason > people will just stop using it. our test suite is unusable the way it is... really it lacks granularity, it takes lots of time and most of the time it looks like it failed since people forget to trap EINA_LOG to capture errors, then you get tons of error messages (although the test reports success, messages confuses users). just the time it takes to run it all is one of the reasons I don't run them that frequently. :-/ -- Gustavo Sverzut Barbieri -------------------------------------- Mobile: +55 (16) 99354-9890 ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
