On 08/27/2013 03:13 PM, Daniel P. Berrange wrote:
On Sun, Aug 25, 2013 at 02:36:35PM -0400, Jesper Pedersen wrote:
On 08/23/2013 09:24 AM, Jesper Pedersen wrote:
Maybe it could be a configuration option until the auto resize is in place.
Attached is a patch for this.
The quality of the preview image needs to be improved, but I havn't
looked in detail (pixbuf / pixbuf-loader) for this yet.
Having worked with it I think the auto resize isn't as important
anymore, since you are likely to use the same screen every time. The
background color for the preview cell is more important now IMHO.
Hmm, so I'm not entirely comfortable with this patch. I don't
think that having a preferences dialog UI for thumbnail size makes
for nice UI. I think the user expectation will be that the thumbnail
size always dynamically change at the resize grip is moved.
Once you have such auto-resize code in place, then I don't think
the preference would make any sense to retain, and so I'm loathe to
add a preference if we know it will be removed / changed. eg when
we have auto-resize, we won't even store the thumbnail size - we'd
just store the position of the resize grip and the thumbnail size
would be calculated to whatever size fits in, given the constraints
of the theme engine.
On your question about quality - the issue is that the thumbnail
loader class is generating thumbnails according to the freedesktop
thumbnail cache spec. We're generating in 'normal' quality though
which is 128x128. We want to have better than that, so I think we
need to switch to use te 'high' quality level which is 256x256.
The second issue is that the scaling from master thumbnail size
to the session browser thumbnail size is being done in the thumbnail
loader itself. This means every time we want to change the size
of the thumbnails we'll need to re-load them all, which sucks.
To fix this, we need to make the thumbnail loader always load
at the fixed 256x256 size. Then make the session browser code
scale them to the final size at time of drawing. This should
let us instant resize images in the session browser, rather
than having to re-create the thumbnail loader as you had todo.
So I think most important thing is to move the final resize
to the rendering part of the session browser. Then switch to
use 256x256 thumbnails. Then the auto-resize stuff should be
pretty easy to add on.
Totally agree with your statements.
I just threw the patch out there, since I was trying to get an overview
of that part of the code, as it looks like I need ~350 px for my setup.
Maybe I'll look at the background color thing first, since it is easier ;)
Thanks for looking at this !
Best regards,
Jesper
_______________________________________________
Entangle-devel mailing list
Entangle-devel@gna.org
https://mail.gna.org/listinfo/entangle-devel
